feat: add icp-cli support to rust/evm_block_explorer#1310
Merged
Conversation
- Add icp.yaml with backend, frontend, and pre-built evm_rpc canister - Migrate frontend from @dfinity/* to @icp-sdk/core + @icp-sdk/bindgen - Add actor.js with cookie-based canister env detection - Rewrite vite.config.js with bindgen plugin and dual dev server (icp-cli/dfx) - Resolve evm_rpc canister ID dynamically via PUBLIC_CANISTER_ID:evm_rpc env var with fallback to hardcoded mainnet ID (using ic0 crate for env var API) - Bump dependencies: candid 0.10.23, evm-rpc-canister-types 5.0.1, ic-cdk 0.17.2 - Commit backend.did for bindgen and add .gitignore for generated files - Update README.md and BUILD.md with icp-cli instructions
viviveevee
approved these changes
Mar 2, 2026
marc0olo
added a commit
to dfinity/icskills
that referenced
this pull request
Mar 9, 2026
…riptions, and dfx references - Separate compatibility (env tools) from prerequisites (library deps) across all 16 skills - Move icp-cli and Node.js from prerequisites to compatibility where needed - Standardize Node.js >= 24 across all skills requiring it - Enrich all skill descriptions with "Use when..." / "Do NOT use for..." triggering clauses - Rename wallet skill to cycles-management (fixes misleading name) - Convert all dfx-format icp.yaml configs to proper recipe syntax - Replace all localhost:4943 references with localhost:8000 (icp-cli default) - Replace dfx commands with icp equivalents in wallet-integration and internet-identity - Fix internet-identity to use ic_env cookie pattern instead of legacy CANISTER_ID_* env vars - Fix evm-rpc config to use pre-built WASM pattern (validated against dfinity/examples#1310) - Remove dfx_test_key references from vetkd, recommend test_key_1 (works locally + mainnet) - Fix cycles-management CLI commands: --icp for mint, --cycles for create, canister status - Add icp-cli installation section - Remove stale canister_ids.json references (icp-cli uses .icp/data/mappings/)
marc0olo
added a commit
to dfinity/icskills
that referenced
this pull request
Mar 10, 2026
…fx references (#82) * refactor: consolidate skills — fix compatibility, prerequisites, descriptions, and dfx references - Separate compatibility (env tools) from prerequisites (library deps) across all 16 skills - Move icp-cli and Node.js from prerequisites to compatibility where needed - Standardize Node.js >= 24 across all skills requiring it - Enrich all skill descriptions with "Use when..." / "Do NOT use for..." triggering clauses - Rename wallet skill to cycles-management (fixes misleading name) - Convert all dfx-format icp.yaml configs to proper recipe syntax - Replace all localhost:4943 references with localhost:8000 (icp-cli default) - Replace dfx commands with icp equivalents in wallet-integration and internet-identity - Fix internet-identity to use ic_env cookie pattern instead of legacy CANISTER_ID_* env vars - Fix evm-rpc config to use pre-built WASM pattern (validated against dfinity/examples#1310) - Remove dfx_test_key references from vetkd, recommend test_key_1 (works locally + mainnet) - Fix cycles-management CLI commands: --icp for mint, --cycles for create, canister status - Add icp-cli installation section - Remove stale canister_ids.json references (icp-cli uses .icp/data/mappings/) * fix: lower Node.js to >= 22 and clean up compatibility fields - Lower Node.js requirement from >= 24 to >= 22 (active LTS) across all skills - Remove Node.js from compatibility where it's not a hard requirement (icp-cli, certified-variables, vetkd) — keep it only for frontend-focused skills (asset-canister, internet-identity, wallet-integration) - Remove redundant Node.js prerequisite from icp-cli (already in Installation) * fix: update CODEOWNERS for wallet → cycles-management rename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
icp.yamlwith backend, frontend asset canister, and pre-builtevm_rpccanister@dfinity/*to@icp-sdk/core+@icp-sdk/bindgen(vite plugin for TypeScript bindings)actor.jswith cookie-based canister env detection (dual icp-cli/dfx support)vite.config.jswithicpBindgenplugin and dual dev server auto-detectionevm_rpccanister ID dynamically viaPUBLIC_CANISTER_ID:evm_rpcenv var (usingic0crate for the system API), falling back to the hardcoded mainnet ID fromevm-rpc-canister-typescandid0.10.23,evm-rpc-canister-types5.0.1,ic-cdk0.17.2, addic01.0.1backend/backend.didfor bindgen and add.gitignorefor generated files